fix(config): restore --es behavior when event.subscribe.enable=false#6756
Closed
halibobo1205 wants to merge 1 commit intotronprotocol:release_v4.8.2from
Closed
fix(config): restore --es behavior when event.subscribe.enable=false#6756halibobo1205 wants to merge 1 commit intotronprotocol:release_v4.8.2from
halibobo1205 wants to merge 1 commit intotronprotocol:release_v4.8.2from
Conversation
The previous flow built EventPluginConfig/FilterQuery only when the config bean had enable=true, so passing the deprecated --es CLI flag against a config with enable=false set eventSubscribe=true but left the plugin config null, causing "Failed to load eventPlugin" at startup. Split applyConfigParams into atomic-bind (eventSubscribe, contractParseSwitch) and buildEventDerivatives (EPC + FilterQuery). The derivative build now runs once at the end of setParam, after CLI overrides have settled, so --es produces a valid EPC and --contract-parse-enable is not clobbered.
Collaborator
Author
|
use #6757 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The previous flow built EventPluginConfig/FilterQuery only when the config bean had enable=true, so passing the deprecated
--esCLI flag against a config with enable=false set eventSubscribe=true but left the plugin config null, causing "Failed to load eventPlugin" at startup.Split applyConfigParams into atomic-bind (eventSubscribe, contractParseSwitch) and buildEventDerivatives (EPC + FilterQuery). The derivative build now runs once at the end of setParam, after CLI overrides have settled, so --es produces a valid EPC and --contract-parse-enable is not clobbered.
Why are these changes required?
restore
--esbehavior whenevent.subscribe.enable=falseThis PR has been tested by:
Follow up
Extra details